Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the renaming of 'title' to 'url' or 'path' according to context #710

Open
Jaifroid opened this issue Mar 4, 2021 · 2 comments
Open
Assignees
Labels
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Mar 4, 2021

When merged #709 will rename getDirEntryByTitle to getDirEntryByPath to avoid the confusion mentioned in #709 (comment). Some of the associated usage of 'title' where url or pathname is meant is cleaned up by that PR where a function directly used the old getDirEntryByTitle. However, there is still lots of ambiguous usage of 'title' throughout the code, and this needs to be cleaned up more thoroughly by a separate PR.

@Jaifroid Jaifroid added this to the v3.3 milestone Mar 4, 2021
@Jaifroid Jaifroid self-assigned this Mar 4, 2021
@Bam92
Copy link

Bam92 commented May 11, 2021

Hi Jaifroid,

Are you still working on this issue or do you need any help?

@Jaifroid
Copy link
Member Author

@Bam92 Thank you for the offer. If you want to take a look, please do. Just make sure you are able to test thoroughly any changes you make on at least Firefox, Chrome and IE11 (we have users with old equipment in developing countries). Sometimes 'title' will need to be changed to 'url', and sometimes to 'path', according to context.

@Jaifroid Jaifroid modified the milestones: v3.9, v4.0 Apr 22, 2023
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants