Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize spelling of "ServiceWorker Mode" vs "Service Worker" #904

Closed
Jaifroid opened this issue Oct 17, 2022 · 6 comments
Closed

Normalize spelling of "ServiceWorker Mode" vs "Service Worker" #904

Jaifroid opened this issue Oct 17, 2022 · 6 comments

Comments

@Jaifroid
Copy link
Member

We are currently inconsistent in sometimes using "Service Worker Mode" and (mostly) "ServiceWorker Mode". In the files touched by #903 I have normalized this to "ServiceWorker Mode" (since it is what we mostly use), but when discussing "Service Workers" (not followed by "Mode", I retain the space. However, there are many other places in the app where this is inconsistent, and it would be good to normalize elsewhere. It's out of scope for #903 because it would introduce a lot of noise into the PR.

@Jaifroid Jaifroid added this to the v3.6 milestone Oct 17, 2022
@Jaifroid Jaifroid self-assigned this Oct 17, 2022
@Jaifroid Jaifroid modified the milestones: v3.6, v3.7 Nov 9, 2022
@Jaifroid Jaifroid modified the milestones: v3.7, v3.8 Jan 3, 2023
@sambhavgupta0705
Copy link

@Jaifroid Can I work on this issue?

@Jaifroid
Copy link
Member Author

Yes, I'll assign you.

@Rbcoder1
Copy link

Is this issue is still open
If no one can solved it then can I try to solved it

@Jaifroid
Copy link
Member Author

@Rbcoder1 There is a PR #970 in progress for this issue. It is nearly completed already.

@Daksh119
Copy link
Contributor

Daksh119 commented Sep 4, 2023

@Jaifroid Let me know if I can complete this existing issue

@Jaifroid
Copy link
Member Author

Jaifroid commented Sep 5, 2023

@Daksh119 I think this is no longer an issue since the internationalization of the app recently. Sorry it wasn't closed earlier. I'd recommend finding another issue to work on.

@Jaifroid Jaifroid closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants