-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize spelling of "ServiceWorker Mode" vs "Service Worker" #904
Labels
Milestone
Comments
@Jaifroid Can I work on this issue? |
Yes, I'll assign you. |
Is this issue is still open |
@Jaifroid Let me know if I can complete this existing issue |
@Daksh119 I think this is no longer an issue since the internationalization of the app recently. Sorry it wasn't closed earlier. I'd recommend finding another issue to work on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are currently inconsistent in sometimes using "Service Worker Mode" and (mostly) "ServiceWorker Mode". In the files touched by #903 I have normalized this to "ServiceWorker Mode" (since it is what we mostly use), but when discussing "Service Workers" (not followed by "Mode", I retain the space. However, there are many other places in the app where this is inconsistent, and it would be good to normalize elsewhere. It's out of scope for #903 because it would introduce a lot of noise into the PR.
The text was updated successfully, but these errors were encountered: