-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPDS catalog must respect the used nameMapper #828
Comments
hi @mgautierfr , I debug the issue seems like its issue with the libkiwix lib not from android side , I have debug the path seems like we are getting the path url on android while creating Library object for calling |
I think I've found the bug. namemapper is used by kiwix::Server to map a book uuid (used internally to identify books) to a name to use in url (both expected url and generated ones). However, the opds_stream always uses the "humanReadableIdFromPath". It is the bug (to fix) and it always have been this way. As kiwix-serve binary use a HumanReadableNameMapper, we never faced the bug. @MohitMaliFtechiz you can check it is the actual issue by using the uuid of the zim instead of the name |
@mgautierfr @veloman-yunkan Sounds like a regression to me. Isn't it? |
This is not a regression from the opds_stream point of view as the bug was always here. |
@mgautierfr Thx for clarification. IMO, we better get it fixed befpre 12.0.0 release. |
I will work on this. |
I'm already working on this |
I've started with some clean-up of OPDS dumper. I've now shared my work as a self contained PR #829. |
I've got the same thing here : #830 |
Per default the Http daemon primitive should work with humanids, not uuids. It woukd be great to use this ticket to have it working like this. |
Describe the bug
On libkiwix 10.1.1 , zim file while opening over hotspot resulting
The requested URL "/" was not found on this server.
.Expected behavior
Its should open the zim file without any issue
Screenshots
Environment
The text was updated successfully, but these errors were encountered: