-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that all readers support bookmarking of page with fragment in URL #107
Comments
|
@benoit74 There is no issue open IMHO, you can open one. |
|
Sorry @benoit74, I'm on an idyllic Greek island, so not really following issues much atm! I confirm there's no bookmark function in KJS. This isn't possible due to the fact that you have to give the browser access to the ZIM each time you restart a session except in the case of browsers that support the File System Access API -- which we support if the browser supports it, but only Chrome(-ium) atm. Do we need to support this for YouTube scraper? |
No worries, and enjoy (and there wasn't any hurry, I just wasn't sure you where following kiwix/overview at all so preferred to tag you ^^)
Good thank you ! I agree it would be complex to implement and maybe not even worth it
Nope, it is the opposite, we want to be sure that readers supporting bookmarking are still working with recent Youtube scraper changes. kiwix-serve is not for instance. Since kiwix-js simply does not support bookmarking, then we are fine. If possible, just keep in mind that should you decide to implement a bookmarking feature one day, then you should consider youtube / freecodecamp ZIMs as good test candidates due to their particularities (I know I would probably not remember it, so no worries if you don't ^^). |
|
With the move to Vue.JS of youtube and freecodecamp scrapers (and soon kolibri and maybe others), all "items" are accessed with a URL containing a fragment like
./index.html#/watch/heating_a_tiny_home_in_winter_with_propane-8CT9?list=winter_prepping-0Xxa
. For kiwix-serve, see e.g. https://library.kiwix.org/viewer#canadian_prepper_winterprepping_en_2024-08/index/heating_a_tiny_home_in_winter_with_propane-8CT9 (which redirects to https://library.kiwix.org/content/canadian_prepper_winterprepping_en_2024-08/index.html#/watch/heating_a_tiny_home_in_winter_with_propane-8CT9?list=winter_prepping-0Xxa with the viewer iframe loaded)This might have an impact on bookmarking feature of readers, which need to save to whole URL including the fragment.
We need to test all readers to confirm which ones are working and/or open proper issues.
The text was updated successfully, but these errors were encountered: