Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all readers support bookmarking of page with fragment in URL #107

Open
3 of 5 tasks
benoit74 opened this issue Sep 2, 2024 · 6 comments
Open
3 of 5 tasks
Assignees
Labels

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Sep 2, 2024

With the move to Vue.JS of youtube and freecodecamp scrapers (and soon kolibri and maybe others), all "items" are accessed with a URL containing a fragment like ./index.html#/watch/heating_a_tiny_home_in_winter_with_propane-8CT9?list=winter_prepping-0Xxa. For kiwix-serve, see e.g. https://library.kiwix.org/viewer#canadian_prepper_winterprepping_en_2024-08/index/heating_a_tiny_home_in_winter_with_propane-8CT9 (which redirects to https://library.kiwix.org/content/canadian_prepper_winterprepping_en_2024-08/index.html#/watch/heating_a_tiny_home_in_winter_with_propane-8CT9?list=winter_prepping-0Xxa with the viewer iframe loaded)

This might have an impact on bookmarking feature of readers, which need to save to whole URL including the fragment.

We need to test all readers to confirm which ones are working and/or open proper issues.

@benoit74 benoit74 self-assigned this Sep 2, 2024
@benoit74 benoit74 added the task label Sep 2, 2024
@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 3, 2024

  • kiwix-android 3.11.1 on Android 13 works OK
  • kiwix-apple version 3.6.0 (173) on MacOS Sonoma 14.5 works OK

@kelson42
Copy link
Contributor

kelson42 commented Sep 3, 2024

@benoit74 There is no issue open IMHO, you can open one.

@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 3, 2024

  • kiwix-js : looks like there is no bookmarking concept / button, you cannot reload a ZIM entry from only a saved URL in your browser, so there is no issue (@Jaifroid did I missed something?)

@Jaifroid
Copy link
Member

Jaifroid commented Sep 3, 2024

Sorry @benoit74, I'm on an idyllic Greek island, so not really following issues much atm! I confirm there's no bookmark function in KJS. This isn't possible due to the fact that you have to give the browser access to the ZIM each time you restart a session except in the case of browsers that support the File System Access API -- which we support if the browser supports it, but only Chrome(-ium) atm. Do we need to support this for YouTube scraper?

@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 3, 2024

I'm on an idyllic Greek island, so not really following issues much atm!

No worries, and enjoy (and there wasn't any hurry, I just wasn't sure you where following kiwix/overview at all so preferred to tag you ^^)

I confirm there's no bookmark function in KJS.

Good thank you ! I agree it would be complex to implement and maybe not even worth it

Do we need to support this for YouTube scraper?

Nope, it is the opposite, we want to be sure that readers supporting bookmarking are still working with recent Youtube scraper changes. kiwix-serve is not for instance. Since kiwix-js simply does not support bookmarking, then we are fine.

If possible, just keep in mind that should you decide to implement a bookmarking feature one day, then you should consider youtube / freecodecamp ZIMs as good test candidates due to their particularities (I know I would probably not remember it, so no worries if you don't ^^).

@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 3, 2024

  • kiwix-desktop: KO, I'll open an issue and update first comment with link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants