Add support for type annotations, typing.TypedDict and python dataclasses #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvllmr
commented
Jul 10, 2022
| @@ -88,7 +88,7 @@ class GenFactory(_.with_metaclass(GenFactoryMeta)): | |||
| t.URL: faker.url, | |||
| t.UUID: faker.uuid, | |||
| t.JSON: faker.json, | |||
| type(None): '', | |||
There was a problem hiding this comment.
Why was there an empty string value?
jvllmr
changed the title
|
Added support for python dataclasses as well. closes #113 |
|
Hey @jvllmr, is there an ETA or any plans to merge this PR? I'm really interested in use faker to randomize dataclass instances =D |
|
I'm not the maintainer so I don't have any influence on the process. |
|
Any opinion on this, @klen ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My implementation of type annotations and typing.TypedDict support.
I hope you don't mind the changed quotes in test_main.py, I forgot that my formatter is enabled :(
closes #166