Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't restrict Faker to version < 12.1 #179

Open
finsterwalder opened this issue Nov 10, 2022 · 6 comments
Open

Don't restrict Faker to version < 12.1 #179

finsterwalder opened this issue Nov 10, 2022 · 6 comments

Comments

@finsterwalder
Copy link

What is the reason to restrict Faker to a version below 12.1?
Looking at the release notes of Faker, I would not expect any breaking changes.
Maybe lift the restriction completely or at least raise it to the current (major-)version?

@Nebucatnetzer
Copy link

With the latest Faker version I get this error:

/opt/hostedtoolcache/Python/3.9.15/x64/lib/python3.9/site-packages/mixer/_faker.py:33: in load
    pcls, lang_found = Factory._get_provider_class(pname, locale)
E   AttributeError: type object 'Factory' has no attribute '_get_provider_class'

@Nebucatnetzer
Copy link

Looks like the change was introduced in 12.1 which explains the restriction to <12.1

@finsterwalder
Copy link
Author

Thanks, Andreas, for trying that. So a (bigger?) change in Mixer is needed, I guess. But then still it would be good to do that and not stay with an old dependency.
Using a private method in an external library is usually a bad idea to start with.... ;-)

@Nebucatnetzer
Copy link

Makes sense to me.
I'm happy to help with testing but I'm not the right person to implement such a change.

@paulschreiber
Copy link

Dependabot tried to update Faker to 16, which won't work because of this mixer restriction. Can mixer be updated to support current faker?

@paulschreiber
Copy link

Faker is now up to 21.0.0. Can you update mixer to support new versions of faker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants