Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec Prober doesn't use the timeout #16

Open
Legion2 opened this issue May 1, 2021 · 0 comments
Open

Exec Prober doesn't use the timeout #16

Legion2 opened this issue May 1, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Legion2
Copy link

Legion2 commented May 1, 2021

For executing Probes, there is a timeout given, which is used by the HTTPGet, HTTPPost and TCPSocket probe but not by the Exec probe. This may result in endless blocking invocation if the probe never returns or something causes it to run very long.

prober/probe/prober.go

Lines 85 to 88 in 7208ea3

func (pb *Prober) executeProbe(p *api_v1.Handler, pod *core.Pod, timeout time.Duration) error {
if p.Exec != nil {
log.Debugf("Exec-Probe Pod: %v, Container: %v, Command: %v", formatPod(pod), p.ContainerName, p.Exec.Command)
res, resp, err := pb.Exec.Probe(pb.Config, pod, p.ContainerName, p.Exec.Command)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants