forked from symplify/phpstan-rules
-
Notifications
You must be signed in to change notification settings - Fork 0
/
SingleIndentationInMethodRule.php
103 lines (89 loc) · 2.73 KB
/
SingleIndentationInMethodRule.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
<?php
declare(strict_types=1);
namespace Symplify\PHPStanRules\ObjectCalisthenics\Rules;
use PhpParser\Node;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\Analyser\Scope;
use Symplify\PHPStanRules\ObjectCalisthenics\Marker\IndentationMarker;
use Symplify\PHPStanRules\ObjectCalisthenics\NodeTraverserFactory\IndentationNodeTraverserFactory;
use Symplify\PHPStanRules\Rules\AbstractSymplifyRule;
use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see https://williamdurand.fr/2013/06/03/object-calisthenics/#1-only-one-level-of-indentation-per-method
*
* @see \Symplify\PHPStanRules\ObjectCalisthenics\Tests\Rules\SingleIndentationInMethodRule\SingleIndentationInMethodRuleTest
*/
final class SingleIndentationInMethodRule extends AbstractSymplifyRule implements ConfigurableRuleInterface
{
/**
* @var string
*/
public const ERROR_MESSAGE = 'Do not indent more than %dx in class methods';
/**
* The depth from nested values inside method, so 2 nestings are from class and method and 1 from inner method
*
* @var int
*/
private const DEFAULT_DEPTH = 5;
public function __construct(
private IndentationMarker $indentationMarker,
private IndentationNodeTraverserFactory $indentationNodeTraverserFactory,
private int $maxNestingLevel = 1
) {
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [ClassMethod::class];
}
/**
* @param ClassMethod $node
* @return string[]
*/
public function process(Node $node, Scope $scope): array
{
$this->indentationMarker->reset();
$nodeTraverser = $this->indentationNodeTraverserFactory->create();
$nodeTraverser->traverse([$node]);
$limitIndentation = $this->maxNestingLevel + self::DEFAULT_DEPTH;
if ($this->indentationMarker->getIndentation() < $limitIndentation) {
return [];
}
$errorMessage = sprintf(self::ERROR_MESSAGE, $this->maxNestingLevel);
return [$errorMessage];
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(self::ERROR_MESSAGE, [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
function someFunction()
{
if (...) {
if (...) {
}
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
function someFunction()
{
if (! ...) {
}
if (!...) {
}
}
CODE_SAMPLE
,
[
'maxNestingLevel' => [2],
]
),
]);
}
}