forked from symplify/phpstan-rules
-
Notifications
You must be signed in to change notification settings - Fork 0
/
TooLongFunctionLikeRule.php
108 lines (94 loc) · 2.62 KB
/
TooLongFunctionLikeRule.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
<?php
declare(strict_types=1);
namespace Symplify\PHPStanRules\ObjectCalisthenics\Rules;
use PhpParser\Node;
use PhpParser\Node\FunctionLike;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Function_;
use PHPStan\Analyser\Scope;
use Symplify\PHPStanRules\Rules\AbstractSymplifyRule;
use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Symplify\PHPStanRules\ObjectCalisthenics\Tests\Rules\TooLongFunctionLikeRule\TooLongFunctionLikeRuleTest
*/
final class TooLongFunctionLikeRule extends AbstractSymplifyRule implements ConfigurableRuleInterface
{
/**
* @var string
*/
public const ERROR_MESSAGE = '%s has %d lines, it is too long. Shorted it under %d lines';
public function __construct(
private int $maxFunctionLikeLength = 20
) {
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Function_::class, ClassMethod::class];
}
/**
* @param Function_|ClassMethod $node
* @return string[]
*/
public function process(Node $node, Scope $scope): array
{
$currentFunctionLikeLength = $this->getNodeLength($node);
if ($currentFunctionLikeLength <= $this->maxFunctionLikeLength) {
return [];
}
$functionLikeType = $this->resolveFunctionLikeType($node);
$errorMessage = sprintf(
self::ERROR_MESSAGE,
$functionLikeType,
$currentFunctionLikeLength,
$this->maxFunctionLikeLength
);
return [$errorMessage];
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(self::ERROR_MESSAGE, [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
function some()
{
if (...) {
return 1;
} else {
return 2;
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
function some()
{
return (...) ? 1 : 2;
}
CODE_SAMPLE
,
[
'maxFunctionLikeLength' => 3,
]
),
]);
}
/**
* @param Function_|ClassMethod $functionLike
*/
private function resolveFunctionLikeType(FunctionLike $functionLike): string
{
if ($functionLike instanceof Function_) {
return 'Function';
}
return 'Method';
}
private function getNodeLength(Node $node): int
{
return $node->getEndLine() - $node->getStartLine();
}
}