forked from symplify/phpstan-rules
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ExcessiveParameterListRule.php
106 lines (94 loc) · 2.62 KB
/
ExcessiveParameterListRule.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
<?php
declare(strict_types=1);
namespace Symplify\PHPStanRules\Rules;
use PhpParser\Node;
use PhpParser\Node\Expr\ArrowFunction;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\FunctionLike;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Function_;
use PHPStan\Analyser\Scope;
use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Symplify\PHPStanRules\Tests\Rules\ExcessiveParameterListRule\ExcessiveParameterListRuleTest
*/
final class ExcessiveParameterListRule extends AbstractSymplifyRule implements ConfigurableRuleInterface
{
/**
* @var string
*/
public const ERROR_MESSAGE = 'Method "%s()" is using too many parameters - %d. Make it under %d';
public function __construct(
private int $maxParameterCount = 10
) {
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [FunctionLike::class];
}
/**
* @param FunctionLike $node
* @return string[]
*/
public function process(Node $node, Scope $scope): array
{
$currentParameterCount = count($node->getParams());
if ($currentParameterCount <= $this->maxParameterCount) {
return [];
}
$name = $this->resolveName($node);
$message = sprintf(self::ERROR_MESSAGE, $name, $currentParameterCount, $this->maxParameterCount);
return [$message];
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(self::ERROR_MESSAGE, [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function __construct($one, $two, $three)
{
// ...
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function __construct($one, $two)
{
// ...
}
}
CODE_SAMPLE
,
[
'maxParameterCount' => 2,
]
),
]);
}
private function resolveName(FunctionLike $functionLike): string
{
if ($functionLike instanceof ClassMethod) {
return (string) $functionLike->name;
}
if ($functionLike instanceof Function_) {
return (string) $functionLike->name;
}
if ($functionLike instanceof ArrowFunction) {
return 'arrow function';
}
if ($functionLike instanceof Closure) {
return 'closure';
}
return 'unknown';
}
}