forked from symplify/phpstan-rules
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathRegexSuffixInRegexConstantRule.php
125 lines (107 loc) · 3.09 KB
/
RegexSuffixInRegexConstantRule.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
<?php
declare(strict_types=1);
namespace Symplify\PHPStanRules\Rules;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\StaticCall;
use PHPStan\Analyser\Scope;
use Symplify\PHPStanRules\NodeAnalyzer\RegexFuncCallAnalyzer;
use Symplify\PHPStanRules\NodeAnalyzer\RegexStaticCallAnalyzer;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Symplify\PHPStanRules\Tests\Rules\RegexSuffixInRegexConstantRule\RegexSuffixInRegexConstantRuleTest
*/
final class RegexSuffixInRegexConstantRule extends AbstractSymplifyRule
{
/**
* @var string
*/
public const ERROR_MESSAGE = 'Name your constant with "_REGEX" suffix, instead of "%s"';
public function __construct(
private RegexFuncCallAnalyzer $regexFuncCallAnalyzer,
private RegexStaticCallAnalyzer $regexStaticCallAnalyzer
) {
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [StaticCall::class, FuncCall::class];
}
/**
* @param StaticCall|FuncCall $node
* @return mixed[]|string[]
*/
public function process(Node $node, Scope $scope): array
{
if ($node instanceof FuncCall) {
if (! $this->regexFuncCallAnalyzer->isRegexFuncCall($node)) {
return [];
}
$firstArgValue = $node->args[0]->value;
return $this->processConstantName($firstArgValue);
}
return $this->processStaticCall($node);
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(self::ERROR_MESSAGE, [
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public const SOME_NAME = '#some\s+name#';
public function run($value)
{
$somePath = preg_match(self::SOME_NAME, $value);
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public const SOME_NAME_REGEX = '#some\s+name#';
public function run($value)
{
$somePath = preg_match(self::SOME_NAME_REGEX, $value);
}
}
CODE_SAMPLE
),
]);
}
/**
* @return string[]
*/
private function processConstantName(Expr $expr): array
{
if (! $expr instanceof ClassConstFetch) {
return [];
}
if ($expr->name instanceof Expr) {
return [];
}
$constantName = (string) $expr->name;
if (\str_ends_with($constantName, '_REGEX')) {
return [];
}
$errorMessage = sprintf(self::ERROR_MESSAGE, $constantName);
return [$errorMessage];
}
/**
* @return string[]
*/
private function processStaticCall(StaticCall $staticCall): array
{
if (! $this->regexStaticCallAnalyzer->isRegexStaticCall($staticCall)) {
return [];
}
$secondArgValue = $staticCall->args[1]->value;
return $this->processConstantName($secondArgValue);
}
}