Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elide endpoint probes when the set of services does not change #410

Open
mattmoor opened this issue Jan 29, 2021 · 2 comments
Open

Elide endpoint probes when the set of services does not change #410

mattmoor opened this issue Jan 29, 2021 · 2 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Issues which should be fixed (post-triage)

Comments

@mattmoor
Copy link
Contributor

A good example of this would be updating traffic: to change percentages (or @vagababov new gradual rollouts) where the set of services in generation: X and generation: X+1 are identical.

We get the former from oldGeneration and the latter from ing here: https://github.com/knative-sandbox/net-contour/blob/7bff03576e1c01114d47c0fdc58dac74a98115db/pkg/reconciler/contour/contour.go#L119

The simplest correct solution is that when the set of services is identical per visibility to elide the endpoint probe, but we could perhaps optimize more generally by excluding services present in both sets and simply eliding when that leaves the empty set 🤔

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2021
@dprotaso
Copy link
Contributor

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 20, 2021
@dprotaso dprotaso added the triage/accepted Issues which should be fixed (post-triage) label May 20, 2021
@nak3 nak3 added this to the v1.4.0 milestone Mar 9, 2022
@carlisia carlisia removed this from the v1.4.0 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

5 participants