Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Set up a better integration testing harness. #2

Closed
mattmoor opened this issue Feb 4, 2018 · 4 comments
Closed

Set up a better integration testing harness. #2

mattmoor opened this issue Feb 4, 2018 · 4 comments
Labels
area/test-and-release Test infrastructure, tests or release enhancement New feature or request

Comments

@mattmoor
Copy link
Member

mattmoor commented Feb 4, 2018

Manually inspecting the output as currently described in the README.md is error-prone and highly undesirable. These should be harnessed into some level of testing that can be orchestrated by Travis or some other CI setup (potentially thru Bazel, e.g. sh_test)

We should run the appropriate configuration against each "builder" (currently Google vs. Cluster).

@imjasonh FYI as I know this is a sore spot.

@mattmoor mattmoor added the enhancement New feature or request label Feb 4, 2018
@mattmoor
Copy link
Member Author

@bobcatfish FYI. I'd like this to track your investigation here which I think covers integration testing.

@bobcatfish
Copy link
Contributor

thanks @mattmoor ! I'm planning to tackle knative/serving#253 for milestone 4 FYI. Also @adrcunha is working on automation for the conformance tests which could maybe be reused for these tests?

@bobcatfish
Copy link
Contributor

I'm planning to tackle knative/serving#253 for milestone 4 FYI

But I tagged it with M3 ... 😅 I am the worst

@adrcunha adrcunha added the area/test-and-release Test infrastructure, tests or release label Mar 21, 2018
@adrcunha
Copy link
Contributor

Test orchestration is now handled by Prow (#106), and the automatic output checking is tracked by #101. Whether the shell script should be rewritten as a go test or not, or handle other cases, is a future improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/test-and-release Test infrastructure, tests or release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants