Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when redeploying function in openshift dont force its internal registry #2172

Open
gauron99 opened this issue Feb 20, 2024 · 4 comments
Open
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@gauron99
Copy link
Contributor

gauron99 commented Feb 20, 2024

This is a followup for #1962

when usign openshift cluster its useful to use its internal registry when deploying images. But you might want to use your own image in different registry like (docker.io etc). One can deploy with f deploy --registry=docker.io/XXX and the correct registry will be used. BUT when redeploying after, openshift registry is used overriding the existing one.

Are you willing to work on this yourself?
yes

either simple logic refactor for redeploy or a complete registry derivation change is needed here

@gauron99 gauron99 added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2024
@gauron99 gauron99 self-assigned this Feb 20, 2024
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2024
@gauron99
Copy link
Contributor Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2024
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2024
@gauron99
Copy link
Contributor Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant