Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configurations of inactive revision's services from istio-proxy for memory efficiency #15454

Open
eddy-oum opened this issue Aug 8, 2024 · 1 comment
Labels
kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@eddy-oum
Copy link
Contributor

eddy-oum commented Aug 8, 2024

Describe the feature

Remove configurations of inactive revision's services from istio-proxy, via istio's exportTo feature.

A revision creates two kubernetes services (rev-00001, rev-00001-private), and both services are discovered by the istio-ingressgateway's istio-proxy in namespace istio-system.
Even when the revisions are inactive, and not accepting traffic, istio-proxy still holds the configuration in the memory.
This can lead to scaling issues when there are many knative services and inactive revisions in a single cluster.

We can remove the endpoint configuration from istio-proxy by annotating the inactive revision's service with networking.istio.io/exportTo: "no-such-ns" (https://istio.io/latest/docs/ops/configuration/mesh/configuration-scoping/#exportto), and remove the annotation when the revision is active again.

@eddy-oum eddy-oum added the kind/feature Well-understood/specified features, ready for coding. label Aug 8, 2024
Copy link

github-actions bot commented Nov 7, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant