Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory config mode should wipe obsolete prefs from NV storage #88

Open
lars-t-hansen opened this issue Mar 31, 2023 · 0 comments
Open
Labels

Comments

@lars-t-hansen
Copy link
Collaborator

Occasionally prefs keys are obsoleted (though never reused, se config.cpp). When we upload a new factory config we should unconditionally remove or set to default the values for all obsoleted keys so that secrets don't leak from old configs left on devices.

The problem currently pertains only to a few names: loc, tsh, tsp, huh and hup, none of which are particularly security-sensitive. So this is not an urgent problem, just a hygiene thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant