Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] TimeField #317

Open
jer3m01 opened this issue Jan 18, 2024 · 2 comments · May be fixed by #529
Open

[Component] TimeField #317

jer3m01 opened this issue Jan 18, 2024 · 2 comments · May be fixed by #529
Labels
SolidHack Participating component for https://hack.solidjs.com/categories-challenges

Comments

@jer3m01
Copy link
Member

jer3m01 commented Jan 18, 2024

https://react-spectrum.adobe.com/react-aria/TimeField.html

@jer3m01 jer3m01 converted this from a draft issue Jan 18, 2024
@jer3m01 jer3m01 added the SolidHack Participating component for https://hack.solidjs.com/categories-challenges label Oct 1, 2024
@dinezh256
Copy link

Hi @jer3m01

I was going through the Kobalte UI components and the reference you shared above for the TimeField component. Could you please advice on how we can implement this?

I noticed that we have a NumberField component. Should we consider using that as a base? Additionally, what attributes should we include for this component? Some that come to my mind are value, onChange, validate, and label.

Also, should we support both hh:mm:ss and hh:mm formats, and what about AM/PM versus 24-hour format options?

@jer3m01
Copy link
Member Author

jer3m01 commented Oct 23, 2024

This component should be similar to NumberField but based on TextField (so don't extend NumberField, copy a similar structure. We might make a more generic component later, but this shouldn't be done in this PR).

The format options should be available as props like https://react-spectrum.adobe.com/react-spectrum/TimeField.html#props.

Please use https://www.npmjs.com/package/@internationalized/date for performing any formatting (similar to how NumberField uses @internationalized/number.

@HBS999 HBS999 linked a pull request Nov 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SolidHack Participating component for https://hack.solidjs.com/categories-challenges
Projects
Status: 📚 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants