Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add no_extension_access_modifier as a default SwiftLint rule #342

Open
ppave opened this issue Apr 27, 2021 · 1 comment
Open

Please add no_extension_access_modifier as a default SwiftLint rule #342

ppave opened this issue Apr 27, 2021 · 1 comment

Comments

@ppave
Copy link

ppave commented Apr 27, 2021

To consider adding one extra rule for SwiftLint default set: https://realm.github.io/SwiftLint/no_extension_access_modifier.html

That's recommended by Google swift guideline (Access Levels section at https://google.github.io/swift/#programming-practices )and personally, I find it useful.

@ppave ppave changed the title Please add extension_access_modifier as a default SwiftLint rules Please add extension_access_modifier as a default SwiftLint rule Apr 27, 2021
@rcritz
Copy link
Contributor

rcritz commented Apr 27, 2021

Thanks for the comment. I'll take a look. We have the unusual circumstance that we discourage access modifiers in many cases since they add cognitive distance in our tutorials. I recognize it's not good software engineering practice and want to rethink whether the policy on access modifiers, which predates me, should change.

I'm going to keep this open for now as a reminder.

@ppave ppave changed the title Please add extension_access_modifier as a default SwiftLint rule Please add no_extension_access_modifier as a default SwiftLint rule Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants