[Enhancement] yabai padding issue

[aspauldingcode]

yabai version irrelevent, happened since 6.x.x, still happening on 7.1.5
macOS version irrelevent, happened since 13.x.x, still happening on 15.0.0
Yabai on macOS has an issue with the gaps.
if you pay really close attention, the spacing on gaps on the left side is correct. the spacing on the right is incorrect. yabai makes the workspace right-side have more space than it should.

Look at the left gap, then the right gap. edges of the window.

I am using this config:

top_padding = 15;
bottom_padding = 15;
left_padding = 15;
right_padding = 15;
window_gap = 15;

however, looking closely at the image, we see that it doesn't matter, the right side has more gap than the left.
Here is another example, just one window:

[aspauldingcode]

here is a capture of left/right with 15 pixels padding.. I will take a capture at 16 pixels.
notice how the main window border won't even be captured on the right. I use the sketchybar program at the top in comparison.

running a line vertically in a photo editing tool, it might be easier to see how it is one pixel off at least on the right side.

I will use non-shadow, sharp-corner application "alacritty" to try representing better. I will set the gaps, and the padding to 1px on all sides to represent the extra space better. compare to sketchybar/ edges:

This issue is extremely hard to show, but it's bothering me on HighDPI retina display.

[koekeishiya]

Maybe I'm not thinking clearly and my math is wrong, but lets say built-in macOS notched-display on M1 macbook with resolution set to 1800x1169.

1800 - left padding (15) - right padding (15) = 1770. So we have 1770px width that is available for tiling.

Split 1770 between two windows with a 15px gap; each window should have a width of: (1770 - 15) * 0.5 = 877.5.
We round down so each window gets a width of 877 (AX API does not allow usage of decimals).

left window
15 + 877 = 892

+15 gap

right window
907 + 877 = 1784

1800 - 1784 = 16 pixel right_padding

the right window can be positioned at 908 instead, but then you get 16px gap between windows instead.

[aspauldingcode]

Hm.. so maybe I should be setting all the gaps to even numbers(?) that makes a lot of sense

[aspauldingcode]

I think visually it would look better if we sacrificed the in-between spacing vs outside. This will look more polished as it is very hard to tell or eyeball the center of the screen versus the edges...

This will being polish to yabai

[koekeishiya]

Adjusted on the latest master.