Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing namespaces for Kohana Core and later modules #622

Open
rjd22 opened this issue Jun 27, 2015 · 6 comments
Open

Implementing namespaces for Kohana Core and later modules #622

rjd22 opened this issue Jun 27, 2015 · 6 comments
Labels
Milestone

Comments

@rjd22
Copy link

rjd22 commented Jun 27, 2015

I'm thinking of opening a new PR on the Kohana core to implement namespaces on all classes and another to move out the Cascading Files to a different repository for backwards compatibility.

This would at least more Kohana Forward to namespacing and make it more compatible to the PSR-4 standards.

I wanted to give a heads-up that I want to do this and was wondering if you people think this would be the right direction to go in.

This will most likely end up in a Kohana 3.5 version since it's mostly backwards compatible.

The discussion in this ticket is related:
#571

@acoulton @enov @lenton @shadowhand would this be appropiate?

@rjd22 rjd22 added the Idea label Jun 27, 2015
@enov
Copy link
Contributor

enov commented Jun 29, 2015

👍

@acoulton
Copy link
Member

👍 would ideally like to see this come with a script to add relevant use statements to end-user code files for quick upgrade.

@JackEllis
Copy link
Contributor

Hell yes, lack of namespaces is really annoying!

@Ikke
Copy link
Contributor

Ikke commented Jul 22, 2015

👍

@rjd22
Copy link
Author

rjd22 commented Feb 4, 2016

@enov @acoulton @Ikke I started working on this in the following branch. #663

I'm taking small steps so the tests won't fail and the merge will be easier. There are some classes that are hard to convert like the UTF8 class so that might need some more work.

Could you please check this PR to see if it's going into the right direction?

@enov
Copy link
Contributor

enov commented Feb 5, 2016

Thanks for the hard work @rjd22.

@neo22s neo22s added this to the 4.0.0 milestone Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants