Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix contexts #304

Closed
1 task done
mvandeberg opened this issue Nov 12, 2024 · 0 comments · Fixed by #309
Closed
1 task done

[BUG]: Fix contexts #304

mvandeberg opened this issue Nov 12, 2024 · 0 comments · Fixed by #309
Labels
bug Something isn't working

Comments

@mvandeberg
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Gossip and peer connection do not properly use contexts, resulting in leaked go routines when gossip is disabled or a peer connection closes. Contexts should be properly used throughout both classes.

Expected behavior

No response

Steps to reproduce

No response

Environment

- OS:

Anything else?

No response

@mvandeberg mvandeberg added the bug Something isn't working label Nov 12, 2024
mvandeberg added a commit that referenced this issue Nov 12, 2024
…ossip is disabled and pass contexts in to calls where applicable
@mvandeberg mvandeberg mentioned this issue Nov 12, 2024
5 tasks
mvandeberg added a commit that referenced this issue Nov 12, 2024
…ossip is disabled and pass contexts in to calls where applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant