Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: P2P Halt #306

Closed
1 task done
mvandeberg opened this issue Nov 12, 2024 · 0 comments · Fixed by #311
Closed
1 task done

[BUG]: P2P Halt #306

mvandeberg opened this issue Nov 12, 2024 · 0 comments · Fixed by #311
Assignees
Labels
bug Something isn't working

Comments

@mvandeberg
Copy link
Member

mvandeberg commented Nov 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

P2P can sometimes halt.

This is caused be a race condition where a child block can be applied before the parent and the result of the messages comes in such that no future attempt is made to apply the block.

Expected behavior

P2P should not halt.

This should be fixed with the following fixes/mitigation:

  • When adding the block entry, application should always be requested.
  • When children are checked, application should be requested and 'forced'. Forced application should loop (with a delay) trying to apply the block until the current application returns (success or failure).

Steps to reproduce

No response

Environment

- OS:

Anything else?

No response

@mvandeberg mvandeberg added the bug Something isn't working label Nov 12, 2024
@mvandeberg mvandeberg self-assigned this Nov 12, 2024
@mvandeberg mvandeberg mentioned this issue Nov 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant