Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve simple kernel timer tool #239

Open
dalg24 opened this issue Feb 15, 2024 · 0 comments
Open

Improve simple kernel timer tool #239

dalg24 opened this issue Feb 15, 2024 · 0 comments
Labels
feature Needed feature but software still is correct on its own Naming Fix naming of files, variable names, functions and other elements of code in repo printedOutput

Comments

@dalg24
Copy link
Member

dalg24 commented Feb 15, 2024 •
edited
Loading

This is good enough for now.

As a follow up I want us to consider using an environment variable (and command-line argument) to select the output format instead of the KOKKOS_TOOLS_TIMER_JSON boolean option.
I also want us to reuse the JSON writing code from kp_json_writer.cpp instead of duplicating.
And finally we need to add tests for that tool.

Originally posted by @dalg24 in #235 (review)
@vlkale vlkale added feature Needed feature but software still is correct on its own printedOutput Naming Fix naming of files, variable names, functions and other elements of code in repo labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Needed feature but software still is correct on its own Naming Fix naming of files, variable names, functions and other elements of code in repo printedOutput
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dalg24 @vlkale