This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Add community health files #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add |
mkostoevr
suggested changes
Jun 17, 2023
Cleverking2003
force-pushed
the
feature/add-community-health-files
branch
from
41e8658
to
41fad97
Compare
mkostoevr
reviewed
Jun 18, 2023
There was a problem hiding this comment.
Thanks!
One small remark. I see the patch also translates line endings, maybe that's not a good idea since it can lead to lot of problems when porting changes from the legacy repo.
Maybe it's better to simply specify a local git config "fetch as is, push LF", so the changed lines are converted automatically. Or just keep newlines as they are for now. This will reduce problems when porting generic (including @Doczom's) changes from the SVN.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Associated issue:
Closes #5