Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exists always returns true after first true response #7

Open
Philip-Wu opened this issue Nov 8, 2016 · 2 comments
Open

exists always returns true after first true response #7

Philip-Wu opened this issue Nov 8, 2016 · 2 comments

Comments

@Philip-Wu
Copy link
Collaborator

After the first response has returned true, any subsequent requests where no matching variants could be found, still return true.

After looking through the code, it turns out that the problem has to do with the way the response is stored.

The BeaconAlleleResponse is stored as a global variable in the beacon.py file.

Not only does this cache the previous result, but will introduce race conditions when serving multiple concurrent requests.

Do you know of any other beacon implementations that sits in front of the GA4GH server that works out of the box?

Thanks

Phil

@Philip-Wu
Copy link
Collaborator Author

Fixed in Branch below

https://github.com/kozbo/Beacon-on-GA4GH-API/tree/Issue7

feel free to merge with master

@kozbo
Copy link
Owner

kozbo commented Jan 9, 2017

Hi @Philip-Wu, Sorry for the long delay getting back to this. Will you please create a PR for this change? I will be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants