Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/ update to NestJS v8 and others #433

Open
smolinari opened this issue Jul 13, 2021 · 17 comments · May be fixed by #434
Open

Support/ update to NestJS v8 and others #433

smolinari opened this issue Jul 13, 2021 · 17 comments · May be fixed by #434

Comments

@smolinari
Copy link

@kpfromer - Can you keep up the maintenance of this package? Would be awesome. Nest is on version 8 and Typegoose is going to be hopefully also going to version 8 soon.

At any rate, this package is falling behind quickly. 😬

Scott

@smolinari smolinari linked a pull request Jul 14, 2021 that will close this issue
@smolinari
Copy link
Author

I've create a PR to update the package. Not sure if it is right or good. Just trying to help.

Scott

@smolinari
Copy link
Author

Since it seems this project has been abandoned or rather I don't want to wait weeks to get updates/ fixes I've decided to fork it to my project and take care of it. I'm not sure what the proper procedure is for doing this. Hope I'm not stepping on anyone's toes, as that is not my intention. I realize people do these projects voluntarily (and hugely appreciate the efforts) and thus, sometimes no longer have the time or even motivation to continue to support them. I do and want to.

If I'm doing anything wrong or out of place, please let me know.

Scott

@kpfromer
Copy link
Owner

Hey Scott, sorry to be so distant with the responses. Things have been quite busy with work and school. I will try to review your code shortly, and thanks for the PR.

I'm not sure what the proper procedure is for doing this. Hope I'm not stepping on anyone's toes, as that is not my intention.

Yeah, my support for this project has been lacking since I am quite busy, so definitely feel free to fork the project!

@smolinari
Copy link
Author

@kpfromer - Hey. Nice to see you. I'd be very interested in your feedback with my PR. To be honest, I'm not the greatest programmer (it's a hobby) and I'm sure there are a ton of mistakes. Also, it seems my reasoning for needing the updating was unfounded and to be honest, I can't remember the reasoning either. I believe it was a mismatch in peer dependencies I was running into, now that Nest is at v8.

At any rate. Just trying to help, as I am using NestJS and Typegoose (and recommend it where I can), and this package is key to that "marriage". 😁

Scott

@shahriar-shojib
Copy link

Typegoose 8 was released today

@smolinari
Copy link
Author

Actually, 8.1 has also been released. 😁

Scott

@DanielEberl
Copy link

Hey, what is going on with the 58 open pull requests?

I can definetly help maintaining this package if you need help. I can take my time since we rely heavily on this package.

Feel free to DM me or add me as a collaborator.

@kpfromer
Copy link
Owner

Hey, what is going on with the 58 open pull requests?

I can definitely help maintaining this package if you need help. I can take my time since we rely heavily on this package.

Feel free to DM me or add me as a collaborator.

Yeah @DanielEberl, I could definitely use the help. College is starting back up, and classes are getting quite tough. Thus I won't have that much time to devote to open-source projects. As for the 58 prs, I think dependabot is not auto merging.

@kpfromer
Copy link
Owner

I am also trying to get Github actions up and working with semantic release, but I have run into a few problems with branch protections. Hopefully when that is working auto merging should be fixed.

@MarcBollmann
Copy link

Any updates on this?

@smolinari
Copy link
Author

Yeah, even my PR is outdated now. Typegoose is at version 9, but it seems everything is still working. Still, this gem of a package should be updated to keep up. 😀

Scott

@MarcBollmann
Copy link

@smolinari I saw your fork seems to be more updated than this one

@smolinari
Copy link
Author

@MarcBollmann - It is. I'd need to do some more updating though. Maybe I'll do it tomorrow.

Scott

@AlexBollmann
Copy link

any updates on this?

@smolinari
Copy link
Author

smolinari commented Oct 25, 2021

I personally have forked it and updated myself. I haven't pushed the changes here, as it seems this project is dead. If anything, later, I'll be posting it as a library package to my project. That will be a while though.

Scott

@kamalkech
Copy link

@smolinari i guess we need to remove this package from our projects, cuz any reactivity or support for this package!!

@AlexBollmann
Copy link

@kamalkech if you have any knowledge how to proceed without this package, please share 😁
I also thought about forking it, but I'm really not that deep into this topic rigt now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants