Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh size limits #484

Open
kpreid opened this issue Apr 3, 2024 · 1 comment
Open

Mesh size limits #484

kpreid opened this issue Apr 3, 2024 · 1 comment
Labels
area: graphics kind: bug Something isn't working as it should

Comments

@kpreid
Copy link
Owner

kpreid commented Apr 3, 2024

fuzz_mesh is hitting the fuzzer-imposed memory limit. We should place explicit limits on the maximum complexity of a mesh so that it not only doesn't hit the fuzzer limit, but is also reasonable for actual rendering.

@kpreid kpreid added kind: bug Something isn't working as it should area: graphics labels Apr 3, 2024
@kpreid
Copy link
Owner Author

kpreid commented Apr 23, 2024

The fuzzer out-of-memory turned out to be not from mesh generation, but from generating a huge LightStorage::propagation_table. I fixed that by constraining the value in 217bd70. However, mesh size limits are still desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics kind: bug Something isn't working as it should
Projects
None yet
Development

No branches or pull requests

1 participant