Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.6 silently requires FSharp.Core 6.0 #30

Open
haraldsteinlechner opened this issue Aug 24, 2022 · 9 comments
Open

1.1.6 silently requires FSharp.Core 6.0 #30

haraldsteinlechner opened this issue Aug 24, 2022 · 9 comments

Comments

@haraldsteinlechner
Copy link
Collaborator

manifests in apps using F# 5.0.. seealso aardvark-platform/aardvark.base#79

@haraldsteinlechner
Copy link
Collaborator Author

what to do here? where is 1.1.6 btw? there seems to be no tag? https://github.com/krauthaufen/Adaptify/tags

@krauthaufen
Copy link
Owner

The msbuild integration and the tool actually require FSharp.Core 6.0 (caused by the compiler services most likely) but the runtime part should not. I guess nuget/paket can't handle that properly since the msbuild task isn't really a runtime dependency and could therefore use a different FSharp.Core version.
I guess the only feasible way to solve this is actually requiring 6.0 in adaptify

@haraldsteinlechner
Copy link
Collaborator Author

i'm checking on this. please push the tag if possible (or is it in another branch?)
image

@krauthaufen
Copy link
Owner

The thing is CI built

@krauthaufen
Copy link
Owner

So i don't have any local tags, maybe something with the CI is wrong, but you can just lookup the Release-Notes history to find the appropriate commit

@haraldsteinlechner
Copy link
Collaborator Author

i put adaptify.core deps into a separate group - #30
this looks promising, but i could not test it properly since using the example sln after running build merge constantly tries to install adaptify as tool 0.0.0.0 which fails. What was the local testing procedure? Running a server side-by-side also does not work - it seems like the decision whether something needs to be installed does not work for me any longer ?!

@krauthaufen
Copy link
Owner

Testing things locally was pretty painful, you need to pin the version somewhere in the code and start a server manually, etc.

@krauthaufen
Copy link
Owner

fixed in 1.1.8

@haraldsteinlechner
Copy link
Collaborator Author

i think this problem was fixed here again: e7797b4

What puzzles me here is "hans" being part of the source path - is this strange? e7797b4#diff-5ebd60ceb88910043c04c5a665d836197d7184488edcf52f590e8fcad6101519R291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants