-
Notifications
You must be signed in to change notification settings - Fork 195
/
dinnerModel.test.js
427 lines (381 loc) · 15.2 KB
/
dinnerModel.test.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
const assert = chai.assert;
const expect = chai.expect;
describe("DinnerModel", () => {
let model = new DinnerModel();
beforeEach(() => {
model = new DinnerModel();
});
// TODO Lab 1: write a test to verify that the number of guests cannot be less than 1.
// If setNumberOfGuests(num) is called with num <= 0, then then number of guests should be set to 1.
describe("all the functions are present", () => {
it("contains all the default functions", () => {
let functions = [
model.setNumberOfGuests,
model.getNumberOfGuests,
model.getSelectedDishes,
model.getFullMenu,
model.getAllIngredients,
model.getTotalMenuPrice,
model.addDishToMenu,
model.removeDishFromMenu,
model.getAllDishes,
model.getDish
];
functions.forEach(func => expect(typeof func).to.equal('function'));
})
});
describe("number of guests", () => {
it("can set and get number of guests", () => {
model.setNumberOfGuests(500);
expect(model.getNumberOfGuests()).to.equal(500);
model.setNumberOfGuests(1);
expect(model.getNumberOfGuests()).to.equal(1);
});
});
describe("getting individual dishes", () => {
let getDishReturnsPromise = model.getDish(1) instanceof Promise;
let getDishReturnsObject = model.getDish(1) instanceof Object;
it("returns either an Object or a Promise", () => {
expect(getDishReturnsObject || getDishReturnsPromise).to.equal(true);
});
if (getDishReturnsPromise) { // if it uses the spoonacular api
it('dishesConst is removed', () => {
expect(typeof dishesConst).to.equal('undefined');
});
it('the apiConfig is correctly configured', () => {
expect(typeof ENDPOINT).to.equal('string');
expect(ENDPOINT).to.not.equal('');
expect(typeof API_KEY).to.equal('string');
expect(API_KEY).to.not.equal('');
});
it("gets the correct dish", (done) => {
model.getDish(559251)
.then((data) => {
expect(data.title).to.equal("Breakfast Pizza");
done();
});
}).timeout(10000);
it("returns undefined if dish is not found", (done) => {
model.getDish(-1)
.then((data) => {
expect(data.code).to.equal(404);
done();
});
}).timeout(10000);
it("catches errors", (done) => {
let oldFetch = fetch;
fetch = () => Promise.reject(new Error('fetching failed'));
model.getDish(5, fetch)
.then((data) => {
expect(true).to.equal(true);
done()
})
.catch(error => {
expect(true).to.equal(false);
done();
});
fetch = oldFetch;
}).timeout(10000);
it("displays a loading indicator when starting fetch and does not display it when the fetch has completed", (done) => {
model.getDish(5)
.finally(() => {
expect(document.querySelector("#loader").style.display).to.equal("none");
done();
});
expect(document.querySelector("#loader").style.display).to.equal("block");
}).timeout(10000);
it("displays and removes the loading indicator, even on network failure", (done) => {
let oldFetch = fetch;
fetch = () => Promise.reject(new Error('fetching failed'));
model.getDish(5)
.finally(() => {
expect(document.querySelector("#loader").style.display).to.equal("none");
done();
});
expect(document.querySelector("#loader").style.display).to.equal("block");
fetch = oldFetch;
}).timeout(10000);
} else if (getDishReturnsObject) { // if it uses the dishesConst
it("gets the correct dish", () => {
const dish1 = model.getDish(1);
expect(dish1.id).to.equal(1);
expect(dish1.name).to.equal("French toast");
const dish100 = model.getDish(100);
expect(dish100.id).to.equal(100);
expect(dish100.name).to.equal("Meat balls");
});
it("returns undefined if dish is not found", () => {
const result1 = model.getDish(-1);
expect(result1).to.equal(undefined);
const result2 = model.getDish();
expect(result2).to.equal(undefined);
});
}
});
describe("filtering for dishes", () => {
let getAllDishesReturnsPromise = model.getAllDishes() instanceof Promise;
let getAllDishReturnsArray = model.getAllDishes() instanceof Array;
it("returns either an Array or a Promise", () => {
expect(getAllDishReturnsArray || getAllDishesReturnsPromise).to.equal(true);
});
if (getAllDishReturnsArray) { // if it uses the dishesConst
it("returns all dishes if no args are specified", () => {
const allDishes = model.getAllDishes();
expect(allDishes.length).to.equal(10);
});
it("returns the correct dish type", () => {
let dishes = model.getAllDishes("starter");
const onlyHasStarters = dishes.every(dish => dish.dishTypes.includes("starter"));
expect(onlyHasStarters).to.equal(true);
dishes = model.getAllDishes("main dish");
const onlyHasMain = dishes.every(dish => dish.dishTypes.includes("main dish"));
expect(onlyHasMain).to.equal(true);
});
it("filters with keywords", () => {
let dishes = model.getAllDishes("", "French");
let allDishesMatch = dishes.every(dish => dish.name.includes("French"));
expect(dishes.length).to.be.above(0);
expect(allDishesMatch).to.equal(true);
dishes = model.getAllDishes("", "Meat");
allDishesMatch = dishes.every(dish => dish.name.includes("Meat"));
expect(dishes.length).to.be.above(0);
expect(allDishesMatch).to.equal(true);
});
it("returns correct dishes with filter and type", () => {
const dishes = model.getAllDishes("starter", "Sour");
const allDishesMatch = dishes.every(
dish => dish.name.includes("Sour") && dish.dishTypes.includes("starter")
);
expect(dishes.length).to.be.above(0);
expect(allDishesMatch).to.equal(true);
});
} else if (getAllDishesReturnsPromise) { // if it uses the spoonacular api
it("returns all dishes if no args are specified", (done) => {
model.getAllDishes()
.then((data) => {
expect(data.length).to.equal(10);
done();
});
}).timeout(10000);
it("returns the correct dish type of main course and pizza", (done) => {
model.getAllDishes("main course", "pizza")
.then((data) => {
const onlyHasPizzas = data.every(dish => dish.title.toLowerCase().indexOf("pizza") > -1);
expect(onlyHasPizzas).to.equal(true);
done();
});
}).timeout(10000);
it("catches errors", (done) => {
let oldFetch = fetch;
fetch = () => Promise.reject(new Error('fetching failed'));
model.getAllDishes('starter', 'Meat')
.then((data) => {
expect(true).to.equal(true);
done()
})
.catch(error => {
expect(true).to.equal(false);
done();
});
fetch = oldFetch;
}).timeout(10000);
it("displays a loading indicator when starting fetch and does not display it when the fetch has completed", (done) => {
model.getAllDishes('starter', 'Meat')
.finally(() => {
expect(document.querySelector("#loader").style.display).to.equal("none");
done();
});
expect(document.querySelector("#loader").style.display).to.equal("block");
}).timeout(10000);
it("displays and removes the loading indicator, even on network failure", (done) => {
let oldFetch = fetch;
fetch = () => Promise.reject(new Error('fetching failed'));
model.getAllDishes('starter', 'Meat')
.finally(() => {
expect(document.querySelector("#loader").style.display).to.equal("none");
done();
});
expect(document.querySelector("#loader").style.display).to.equal("block");
fetch = oldFetch;
}).timeout(10000);
}
});
describe("menu", () => {
let getDishReturnsPromise = model.getDish(1) instanceof Promise;
let getDishReturnsObject = model.getDish(1) instanceof Object;
if (getDishReturnsPromise) { // if it uses the spoonacular api
it("can add dishes", (done) => {
model.getDish(559251)
.then((data) => {
model.addDishToMenu(data);
expect(model.getFullMenu().length).to.equal(1);
expect(model.getFullMenu()[0].id).to.equal(559251);
done();
});
}).timeout(10000);
it("can remove dishes", (done) => {
model.getDish(559251)
.then((data) => {
model.addDishToMenu(data);
expect(model.getFullMenu().length).to.equal(1);
expect(model.getFullMenu()[0].id).to.equal(559251);
model.removeDishFromMenu(559251);
expect(model.getFullMenu().length).to.equal(0);
expect(model.getFullMenu()).to.not.include(data);
done();
});
}).timeout(10000);
it("can find the dishes of a specific type on the menu", (done) => {
model.getDish(559251)
.then((data) => {
model.addDishToMenu(data);
expect(model.getFullMenu().length).to.equal(1);
expect(model.getFullMenu()[0].id).to.equal(559251);
model.removeDishFromMenu(559251);
expect(model.getFullMenu().length).to.equal(0);
expect(model.getFullMenu()).to.not.include(data);
done();
});
}).timeout(10000);
} else if (getDishReturnsObject) { // if it uses dishesConst
it("can add dishes", () => {
model.addDishToMenu(model.getDish(1));
expect(model.getFullMenu()).to.include(model.getDish(1));
model.addDishToMenu(model.getDish(100));
expect(model.getFullMenu()).to.include(model.getDish(1));
expect(model.getFullMenu()).to.include(model.getDish(100));
});
it("can remove dishes", () => {
model.addDishToMenu(model.getDish(1));
// dish 1 should be in the menu
expect(model.getFullMenu()).to.include(model.getDish(1));
model.removeDishFromMenu(1);
// should now be removed
expect(model.getFullMenu()).to.not.include(model.getDish(1));
});
it("can find the dishes of a specific type on the menu", () => {
model.addDishToMenu(model.getDish(1)); // starter
model.addDishToMenu(model.getDish(2)); // starter
model.addDishToMenu(model.getDish(100)); // main dish
let starters = model.getSelectedDishes('starter');
expect(starters).to.include(model.getDish(1));
expect(starters).to.include(model.getDish(2));
expect(starters).to.not.include(model.getDish(100));
})
}
});
describe("getting all ingredients", () => {
let getDishReturnsPromise = model.getDish(1) instanceof Promise;
let getDishReturnsObject = model.getDish(1) instanceof Object;
if (getDishReturnsPromise) { // if it uses the spoonacular api
it("returns an array of all the ingredients of all the dishes on the menu", (done) => {
model.getDish(1)
.then((dish) => {
model.addDishToMenu(dish);
return model.getDish(2);
})
.then(dish => {
model.addDishToMenu(dish);
expect(model.getFullMenu().length).to.equal(2);
expect(model.getAllIngredients().length).to.equal(13);
let expectedIngredientsNames = ['anchovies', 'baking powder', 'egg', 'flour', 'sage leaves', 'salt', 'seltzer water', 'vegetable oil', 'anchovies', 'bread', 'garlic clove', 'olive oil', 'scallions'];
let actualIngredientsNames = model.getAllIngredients().map(ingredient => ingredient.name);
expect(expectedIngredientsNames).to.deep.equal(actualIngredientsNames);
done();
})
}).timeout(10000);
} else if (getDishReturnsObject) { // if it uses the dishesConst
it("returns an array of all the ingredients of all the dishes on the menu", () => {
model.addDishToMenu(model.getDish(1));
model.addDishToMenu(model.getDish(2));
let expectedIngredients = [{
'name': 'eggs',
'amount': 0.5,
'unit': '',
}, {
'name': 'milk',
'amount': 30,
'unit': 'ml',
}, {
'name': 'brown sugar',
'amount': 7,
'unit': 'g',
}, {
'name': 'ground nutmeg',
'amount': 0.5,
'unit': 'g',
}, {
'name': 'white bread',
'amount': 2,
'unit': 'slices',
}, {
'name': 'active dry yeast',
'amount': 0.5,
'unit': 'g',
}, {
'name': 'warm water',
'amount': 30,
'unit': 'ml',
}, {
'name': 'all-purpose flour',
'amount': 15,
'unit': 'g',
}];
expect(model.getAllIngredients().length).to.equal(expectedIngredients.length);
model.getAllIngredients().forEach(ingredient => {
expect(expectedIngredients).to.have.deep.include(ingredient);
});
});
}
});
describe("calculating total menu price", () => {
let getDishReturnsPromise = model.getDish(1) instanceof Promise;
let getDishReturnsObject = model.getDish(1) instanceof Object;
if (getDishReturnsPromise) { // if it uses the spoonacular api
it("calculates the correct menu price", (done) => {
model.setNumberOfGuests(2);
model.getDish(1)
.then((dish) => {
model.addDishToMenu(dish);
return model.getDish(2);
})
.then(dish => {
model.addDishToMenu(dish);
expect(Math.abs(model.getTotalMenuPrice() - 1285.14)).to.be.below(0.01);
done();
})
}).timeout(10000);
} else if (getDishReturnsObject) { // if it uses the dishesConst
it("calculates the correct menu price", () => {
model.setNumberOfGuests(2);
model.addDishToMenu(model.getDish(1));
model.addDishToMenu(model.getDish(2));
expect(Math.abs(model.getTotalMenuPrice() - 151.4)).to.be.below(0.01);
});
}
});
describe("functional code. (These tests don't necessarily have to be passed, but passing them is a good sign.)", () => {
let testFunctional = (method) => {
let r = /(for\s*\(|forEach\s*\()/g;
let str = method.toString();
expect(r.test(str)).to.equal(false);
};
let methodNames = [
'setNumberOfGuests',
'getNumberOfGuests',
'getSelectedDishes',
'getFullMenu',
'getAllIngredients',
'getTotalMenuPrice',
'addDishToMenu',
'removeDishFromMenu',
'getAllDishes',
'getDish'
];
methodNames.forEach(methodName => {
it(`${methodName} is functional`, () => {
testFunctional(model[methodName])
})
});
});
});