Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support karmor tool on windows #270

Open
3 tasks
nyrahul opened this issue Feb 16, 2023 · 14 comments · May be fixed by #471
Open
3 tasks

support karmor tool on windows #270

nyrahul opened this issue Feb 16, 2023 · 14 comments · May be fixed by #471
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nyrahul
Copy link
Contributor

nyrahul commented Feb 16, 2023

Currently, karmor tool can be installed only from linux. It should be possible to install kubearmor using karmor client tool on windows.

Tasks:

  • Code change to compile on windows
  • karmor client release for windows. Release process change.
  • Installation command change.
@nyrahul nyrahul added enhancement New feature or request good first issue Good for newcomers labels Feb 16, 2023
@daemon1024
Copy link
Member

Ref #50

@akashsawan1
Copy link

Hey @nyrahul ,I would like to take this one on

@nyrahul
Copy link
Contributor Author

nyrahul commented May 29, 2023

Hey @nyrahul ,I would like to take this one on

Great. Thank you for your interest.

@akashsawan1
Copy link

Could you help me with some resource to get started.

@nyrahul
Copy link
Contributor Author

nyrahul commented May 29, 2023

Could you help me with some resource to get started.

KubeArmor uses goreleaser to get the releases prepared for Mac and Linux. You will have to enable windows in there and check if the compilation etc works fine. I guess you will run into issues that will need fixes.

@nyrahul
Copy link
Contributor Author

nyrahul commented Dec 2, 2023 via email

@EraKin575
Copy link
Contributor

@nyrahul is this issue still relevant?

@nyrahul
Copy link
Contributor Author

nyrahul commented Jun 25, 2024

@nyrahul is this issue still relevant?

Yes imo it is still relevant. Cc: @daemon1024

@EraKin575
Copy link
Contributor

please assign me this issue

@daemon1024 daemon1024 assigned EraKin575 and unassigned akashsawan1 Jun 27, 2024
@daemon1024
Copy link
Member

@EraKin575 thanks for taking it up. I see you have asked to be assigned on a couple of issues, let's focus on other issues once we wrap this up. Appreciate the enthusiasm!

@Manik2708
Copy link
Contributor

Would like to work on it, please assign @daemon1024 @nyrahul

@Manik2708
Copy link
Contributor

@nyrahul So I tried compiling the application for windows. I got errors from following packaged:

  1. Probe: This package uses sys/unix, so I seperated the logic of printing probe data for windows and unix where unix will print data even if the enviornment is not k8s but in windows if k8s enviornment is not found then it will throw error.
  2. VM: This package uses cilium which can't be compiled on windows, so every command related to this package will not be available on windows.
  3. Profile: This package uses an accunox package which is using cilium package, so again this command can't be made available for windows.
    @nyrahul @daemon1024 Please see if these commands can be removed for windows build. Or are there some alternatives?

@Manik2708
Copy link
Contributor

Manik2708 commented Dec 7, 2024

@nyrahul So I tried compiling the application for windows. I got errors from following packaged:

  1. Probe: This package uses sys/unix, so I seperated the logic of printing probe data for windows and unix where unix will print data even if the enviornment is not k8s but in windows if k8s enviornment is not found then it will throw error.
  2. VM: This package uses cilium which can't be compiled on windows, so every command related to this package will not be available on windows.
  3. Profile: This package uses an accunox package which is using cilium package, so again this command can't be made available for windows.
    @nyrahul @daemon1024 Please see if these commands can be removed for windows build. Or are there some alternatives?

Conclusively it can be said that Karmor in windows will only display data when KubeArmor is running in k8s enviornment and also I think we can make profiling available for windows because cilium is not used in profile, so by picking that code from accunox instead of using external package we can make compilation for windows success

@nyrahul
Copy link
Contributor Author

nyrahul commented Dec 7, 2024

@daemon1024 , I think we should have any dep on Cilium anymore for karmor .. isn't it?

@Manik2708 Manik2708 linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants