Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ramesh Reddy as a member of Kubeflow Organization and member of Model Registry Team #649

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add Ramesh Reddy as a member of Kubeflow Organization and member of Model Registry Team #649

merged 1 commit into from
Feb 2, 2024

Conversation

rareddy
Copy link
Contributor

@rareddy rareddy commented Feb 1, 2024

Add Ramesh Reddy as a member of the Kubeflow Organization and member of Model Registry Team

PRs to my contributions

Test your PR by running the following:

$pytest test_org_yaml.py
============================================================= test session starts ==============================================================
platform linux -- Python 3.12.1, pytest-7.3.2, pluggy-1.2.0
rootdir: /home/rareddy/development/kubeflow/internal-acls/github-orgs
collected 1 item                                                                                                                               

test_org_yaml.py .                                                                                                                       [100%]

============================================================== 1 passed in 0.16s ===============================================================

@google-oss-prow Google OSS Prow
Copy link

Hi @rareddy. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andreyvelich
andreyvelich reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you for all of the great contributions that you have done @rareddy!
Looking forward to our future work!
/assign @james-jwu @zijianjoy

@google-oss-prow google-oss-prow bot added the lgtm label Feb 1, 2024
@terrytangyuan
Copy link
Member

/lgtm

@zijianjoy
Copy link
Contributor

/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 04e13a6 into kubeflow:master Feb 2, 2024
3 checks passed
@rareddy
Copy link
Contributor Author

rareddy commented Feb 2, 2024

Thank you @zijianjoy @andreyvelich and @terrytangyuan for your support.

@jbottum
Copy link
Contributor

jbottum commented Feb 5, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@chensun chensun Awaiting requested review from chensun

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@terrytangyuan terrytangyuan

@andreyvelich andreyvelich

@zijianjoy zijianjoy

@james-jwu james-jwu

Labels
approved lgtm needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rareddy @terrytangyuan @zijianjoy @jbottum @andreyvelich @james-jwu