Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seaweedfs to contrib #2826

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

pschoen-itsc
Copy link

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I added seaweedfs to contrib which could be a replacement for minio

📦 List any dependencies that are required for this change

🐛 If this PR is related to an issue, please put the link to the issue here.

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

/ok-to-test

@juliusvonkohout
Copy link
Member

And first of all thank you very much for the PR.

@juliusvonkohout juliusvonkohout self-assigned this Aug 1, 2024
@juliusvonkohout
Copy link
Member

This is a follow up of the discussion in kubeflow/pipelines#10998

@pschoen-itsc
Copy link
Author

pschoen-itsc commented Sep 2, 2024

One current problem is getting an artifact via the Artifacts view in the UI. mlpipeline-ui crashes because of a missing region parameter in the js minio client. Not sure why this problem appears when using seaweedfs, because there is no change in configuration there.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from juliusvonkohout. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pschoen-itsc pschoen-itsc force-pushed the add-seaweedfs-to-contrib branch 2 times, most recently from 0ac99d3 to f4eb716 Compare September 3, 2024 16:40
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Sep 3, 2024
@google-oss-prow google-oss-prow bot added size/L and removed size/XXL labels Sep 3, 2024
@juliusvonkohout
Copy link
Member

/ok-to-test

Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
@pschoen-itsc
Copy link
Author

Pipeline should succeed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants