Status of KFP V2

[AndersBennedsgaard]

Hello 😃

I was curious: what is the status of running a pure V2 instance of pipelines? Has it been tested and is used in production?

#10402 and other issues makes it seem as if it should be possible now, but I still see a lot of references to code from apiv1beta1 in the API server, several CRDs still use v1beta1 such as the ScheduledWorkflow (which might be intentional since it doesn't have to be versioned the same as the rest of the project, and so on.

Personally, I've hit the issue that the API Server requires setting the ML_PIPELINE_VISUALIZATIONSERVER_SERVICE_HOST and ML_PIPELINE_VISUALIZATIONSERVER_SERVICE_PORT environment variables, even though the visualization server isn't used in V2 (I've removed the visualization server from my cluster, and most things seems to be running smoothly). Setting bogus values for these environment variables makes the API server run again. The code for that can be seen here:

pipelines/backend/src/apiserver/main.go

Lines 150 to 156 in 45f3457

	apiv1beta1.RegisterVisualizationServiceServer(
	s,
	server.NewVisualizationServer(
	resourceManager,
	common.GetStringConfig(cm.VisualizationServiceHost),
	common.GetStringConfig(cm.VisualizationServicePort),
	))

I've also hit an issue with the central dashboard erroring out with the pipelines card on the front page (see kubeflow/kubeflow#7584)

[rimolive]

We have users running KFPv2 for a while, so I'd assume they are already running in production. The need to set the viz server env vars and the references to apiv2beta1 are for backward compatibility purposes and we plan to remove in future releases.

[AndersBennedsgaard]

Wouldn't it make sense to cover V1-specific code in an if backwards_compatible {} block, so the API server and more wouldn't have to have a large amount of redundant code running? Of course backwards_compatible could be true by default.

I'm specifically thinking about stuff like this which spawns multiple goroutines:

pipelines/backend/src/apiserver/main.go

Lines 143 to 157 in 45f3457

	apiv1beta1.RegisterExperimentServiceServer(s, sharedExperimentServer)
	apiv1beta1.RegisterPipelineServiceServer(s, sharedPipelineServer)
	apiv1beta1.RegisterJobServiceServer(s, sharedJobServer)
	apiv1beta1.RegisterRunServiceServer(s, sharedRunServer)
	apiv1beta1.RegisterTaskServiceServer(s, server.NewTaskServer(resourceManager))
	apiv1beta1.RegisterReportServiceServer(s, sharedReportServer)
	apiv1beta1.RegisterVisualizationServiceServer(
	s,
	server.NewVisualizationServer(
	resourceManager,
	common.GetStringConfig(cm.VisualizationServiceHost),
	common.GetStringConfig(cm.VisualizationServicePort),
	))
	apiv1beta1.RegisterAuthServiceServer(s, server.NewAuthServer(resourceManager))