Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate presubmit tests to GH Actions #10746

Closed
Tracked by #10744
rimolive opened this issue Apr 24, 2024 · 13 comments
Closed
Tracked by #10744

Migrate presubmit tests to GH Actions #10746

rimolive opened this issue Apr 24, 2024 · 13 comments
Assignees
Labels
good first issue help wanted The community is welcome to contribute. kind/feature

Comments

@rimolive
Copy link
Member

Description

As part of the main tracker issue, we need to migrate presubmit tests to GH Actions.

Acceptance Criteria

Impacted by this bug? Give it a 👍.

@rimolive
Copy link
Member Author

/remove-kind bug
/kind feature
/good-first-issue

Copy link

@rimolive:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-kind bug
/kind feature
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pratikkumar-mohite
Copy link

I would like to work on this, if no one is working, please assign

@kark7
Copy link

kark7 commented Jul 13, 2024

/assign

@kark7
Copy link

kark7 commented Jul 13, 2024

/unassign

@liavweiss
Copy link
Contributor

liavweiss commented Aug 7, 2024

Hey @rimolive, regarding the presubmit tests, does the "tests" mean all the presubmit tests that are still not on Git Hub action?

  • presubmit-tests-tfx.sh
  • presubmit-tests-with-pipeline-deployment.sh
    ?

@liavweiss
Copy link
Contributor

I'm interested in working on this issue, I am waiting for an answer to the question above.
/assign

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 7, 2024

@liavweiss there's only one test that we still need to migrate: #11052
It doesn't seem a trivial one though. If you want to try it, you can use #11048 as a reference.

Other issues that you can work on are:

@liavweiss
Copy link
Contributor

liavweiss commented Aug 11, 2024

ok thanks for the answer, I won't work on it.

@liavweiss
Copy link
Contributor

/unassign

@sky0walker99
Copy link

I’d like to contribute to this issue and work on the remaining test migration. I will refer to #11048 as suggested. Please let me know if there are any additional details or steps I should follow before getting started.
/assign

@hbelmiro
Copy link
Contributor

@sky0walker99 thank you for trying to contribute. But this was already done.

/close

Copy link

@hbelmiro: Closing this issue.

In response to this:

@sky0walker99 thank you for trying to contribute. But this was already done.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted The community is welcome to contribute. kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants