-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix environment variables names #11013
Conversation
@diegolovison: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out by creating a pipeline and a run using a yaml created out of the previous example snippet. Observed this error on run creation:
File "/tmp/tmp.j8rF6VFIdK/ephemeral_component.py", line 9, in print_secret
print(os.environ['my-secret'])
File "/usr/lib64/python3.9/os.py", line 679, in __getitem__
raise KeyError(key) from None
KeyError: 'my-secret'
Generated a yaml out of this fixed example snippet, created a pipeline and run. Run completed successfully.
[KFP Executor 2024-07-16 20:09:45,963 INFO]: Looking for component `print_secret` in --component_module_path `/tmp/tmp.Lz61ANvhsm/ephemeral_component.py`
[KFP Executor 2024-07-16 20:09:45,963 INFO]: Loading KFP component "print_secret" from /tmp/tmp.Lz61ANvhsm/ephemeral_component.py (directory "/tmp/tmp.Lz61ANvhsm" and module name "ephemeral_component")
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
forwarding to @chensun for final review and approval :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@diegolovison could you please rebase? That should remove the failing Prow test and this PR shall get merged. |
Signed-off-by: Diego Lovison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Diego Lovison <[email protected]>
Signed-off-by: Diego Lovison <[email protected]>
Description of your changes:
Fix environment variable names
The current code is using
os.environ['my-secret']
but we are setting the environment variable to beSECRET_VAR
The code
os.environ['my-secret']
will return an errorThe goal of this PR is to fix the doc issue.
Checklist: