-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fix(Backend+SDK): Update kubernetes.use_secret_as_env to accept secret name dynamically at runtime #11121
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ddalvi <[email protected]>
7c6aa5c
to
a54ee9c
Compare
Looks good to me. |
@chensun bumping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of your changes:
Resolves #10914
Similar to #11039
PipelineParameterChannel
type this way:use_secret_as_env
function.{{secret_name}}
template string representation for secret names in the compiled DSL.Checklist: