Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] KFP 2.3.0 & KFP SDK 2.9.0 release tracker #11148

Closed
chensun opened this issue Aug 29, 2024 · 7 comments
Closed

[Release] KFP 2.3.0 & KFP SDK 2.9.0 release tracker #11148

chensun opened this issue Aug 29, 2024 · 7 comments
Assignees

Comments

@chensun
Copy link
Member

chensun commented Aug 29, 2024

Release owner: @chensun
Release instructions: https://github.com/kubeflow/pipelines/blob/master/RELEASE.md

Tentative release timeline: early to mid September

@chensun chensun added kind/bug and removed kind/bug labels Aug 29, 2024
@chensun chensun self-assigned this Aug 29, 2024
@chensun
Copy link
Member Author

chensun commented Aug 29, 2024

Current release blockers:

  • Post-submit tests failures:
    image

@HumairAK
Copy link
Collaborator

I would like to propose we also get this merged in: #11058
cc @zijianjoy before we cut a release, it's a very apparent bug that users will immediately hit

@hbelmiro
Copy link
Contributor

@chensun it seems like these tests are not expected to run on pushes. See, for example,

export PULL_NUMBER="${{ github.event.inputs.pull_number || github.event.pull_request.number }}"
and
if os.environ.get('PULL_NUMBER') is not None:

AssertionError: 1 != 0 :   WARNING: Did not find branch or tag 'refs/pull//merge', assuming revision or ref.

I created a test PR and all tests are passing: #11150

I'll take a closer look to fix them.

@hbelmiro
Copy link
Contributor

@chensun it seems like we also have some flaky tests.

As a workaround, can we ignore the failing tests in the master branch and use my test PR instead? Just while we fix the failing tests.
We can rebase and/or rerun the tests (with rerun-all) as much as needed before releasing.

If the failing tests block some automation, we can disable them from running on pushes. (Also, just while we fix them)

Please let me know if that works for you and if I need to disable them from running on pushes.

I created this issue to track this work.

@HumairAK
Copy link
Collaborator

I'm not sure if this is included as part of the instructions, but please also rebuild driver/launcher images, as these have also undergone changes.

@chensun
Copy link
Member Author

chensun commented Sep 5, 2024

@chensun it seems like these tests are not expected to run on pushes. See, for example,

export PULL_NUMBER="${{ github.event.inputs.pull_number || github.event.pull_request.number }}"

and

if os.environ.get('PULL_NUMBER') is not None:

AssertionError: 1 != 0 :   WARNING: Did not find branch or tag 'refs/pull//merge', assuming revision or ref.

I created a test PR and all tests are passing: #11150

I'll take a closer look to fix them.

Thank you for the investigation. It sounds good to me to ignore the failure and unblock the release. I can probably do the release tomorrow.

@chensun
Copy link
Member Author

chensun commented Sep 10, 2024

Release notes:
https://github.com/kubeflow/pipelines/releases/tag/2.3.0
https://github.com/kubeflow/pipelines/releases/tag/sdk-2.9.0

@chensun chensun closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants