Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): remove unused function argument #11425

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

leseb
Copy link
Contributor

@leseb leseb commented Dec 2, 2024

Description of your changes:

5bb5a60 fix(backend): remove unused function argument

commit 5bb5a60
Author: Sébastien Han [email protected]
Date: Mon Dec 2 15:07:30 2024 +0100

fix(backend): remove unused function argument

`outputDefinitions` has not been used since
`collectOutPutParametersFromCache()` was removed in
0be57c38802b85d0b09b703e60b1b3131a1b9863.

Signed-off-by: Sébastien Han <[email protected]>

Checklist:

`outputDefinitions` has not been used since
`collectOutPutParametersFromCache()` was removed in
0be57c3.

Signed-off-by: Sébastien Han <[email protected]>
Copy link

Hi @leseb. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@HumairAK
Copy link
Collaborator

HumairAK commented Dec 3, 2024

/approve

Thanks @leseb !

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7f2278f into kubeflow:master Dec 3, 2024
19 checks passed
@leseb leseb deleted the rm-unused branch December 3, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants