Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to release 2.0-alpha7 with bug fixes and awaited features for Kubeflow 1.7 release #8938

Closed
surajkota opened this issue Mar 7, 2023 · 5 comments · Fixed by kubeflow/manifests#2404

Comments

@surajkota
Copy link
Contributor

surajkota commented Mar 7, 2023

Hi @zijianjoy @chensun, I am opening this issue to request for releasing a patch on top of 2.0-alpha.6 instead of using 2.0-alpha.6 release for Kubeflow-1.7 release. 2.0-alpha6 was released 5 months ago which is in the same timeframe as Kubeflow-1.6 release and considering the frequency of Kubeflow releases, users have to wait a long time for some of the big fixes and features which have been merged since then. Following are the issues/PRs I propose to be made available in the pipelines version included in 1.7 Kubeflow release (maybe 2.0-alpha7):

  1. (Regression in Kubeflow-1.6.1) fix(frontend): Use browser-compatible atob instead of Buffer for frontend graph decompression. Fixes #7655 #8343
  2. (Regression in Kubeflow-1.7.rc1) fix(manifests): Change mysql default binlog expire to 10 days. Fixes #8552 #8553. This has been reported in RC1 testing, see [v1.7.0-rc.1] MySQL binary logs grow fast and indefinitely in size manifests#2402. Although 10 days/this fix does not seem to be sufficient
  3. (Feature) feat(frontend): Implement aws-js-sdk crendentials to support IRSA for s3 #8651 solves a long standing feature request and we/AWS would like to make it available in 1.7
  4. (Fix/feature) feat(backend): Make cache-server webhook port number configurable #8401
  5. PRs which are updating deprecated and vulnerable packages e.g. ones opened by dependabot with chore(deps)

(reduce scope because of WG bandwidth)Nice to have:
-(Feature) #8511. @kimwnasptd to comment if this is much awaited feature
- #8384
- #8793

I have compiled this list based on customer contacts we received and looking at feat/fix(frontend) or feat/fix(backend) related to KFP v1 from 2.0.0-alpha.6...2.0.0-beta.0.

Note: I have skipped sdk related PRs assuming user can update sdk independently and it does not require backend changes but I might have missed some w.r.t. this because I did not go through each PR description

@kubeflow/release-team @kubeflow/release-managers @DomFleischmann

@kimwnasptd since he wanted to add some PRs they are waiting on. Please add if I missed them

Please let me know your thoughts

@surajkota
Copy link
Contributor Author

Pipelines WG is working on a patch release on top of alpha6 which will also include another fix for sql logs issue(#8941). They have limited bandwidth right now and considering the recent code refractor, release cycle timeframe, they are able to include only the first 3 items for the patch release.

Appreciate the bias for action from Chen and pipelines WG for helping with resolution of these issues in 1.7 release

cc @DomFleischmann can we plan for RC2 when this release is out?

@chensun
Copy link
Member

chensun commented Mar 8, 2023

Created the release branch and cherry-picked #8343 and #8651, currently waiting for #8941 to be merged into master first.
I didn't encounter any merge conflict during the cherrypick so far.

https://github.com/kubeflow/pipelines/commits/release-2.0-alpha

@DomFleischmann
Copy link

@chensun What is the state of this new release? We are on a very tight schedule with the 1.7 release supposedly happening on March 15th. I'm willing to delay this date but we need something as soon as possible to give people enough time to test.

@surajkota
Copy link
Contributor Author

Tag was cut yesterday, created a PR to sync the manifests - https://github.com/kubeflow/manifests/pull/2404/files

Thanks @chensun. Assuming we are good to use the tag for next RC, let us know this is not the case

@chensun
Copy link
Member

chensun commented Mar 9, 2023

Yes, tag was cut yesterday, and release is now published: https://github.com/kubeflow/pipelines/releases/tag/2.0.0-alpha.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants