feat(Backend + SDK): Update kfp backend and kubernetes sdk to support pod labels and annotations #10393
Conversation
google-oss-prow
bot
requested review from
chensun,
connor-mccarthy and
zijianjoy
There was a problem hiding this comment.
SDK changes LGTM! Thank you!
/assign @chensun for backend changes review.
|
/assign @chensun |
|
Thank you @Tomcli |
|
@roytman: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chensun Could you help review this PR? Thank you. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@Tomcli: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
… pod labels and annotations (kubeflow#10393) * update kfp kubernetes sdk to include pod labels and annotations * fix unit test output order * add podmetadata changes * update argo compiler to support pod metadata * update tests * update go mod to use the latest kubernetes_platform package * update licenses * address comments * update kubernetes_platform package to include the latest spec --------- Co-authored-by: Chen Sun <[email protected]>
… pod labels and annotations (kubeflow#10393) * update kfp kubernetes sdk to include pod labels and annotations * fix unit test output order * add podmetadata changes * update argo compiler to support pod metadata * update tests * update go mod to use the latest kubernetes_platform package * update licenses * address comments * update kubernetes_platform package to include the latest spec --------- Co-authored-by: Chen Sun <[email protected]>
|
Can you release a new version of kfp-kubernetes? We are missing this functionality |
… pod labels and annotations (kubeflow#10393) * update kfp kubernetes sdk to include pod labels and annotations * fix unit test output order * add podmetadata changes * update argo compiler to support pod metadata * update tests * update go mod to use the latest kubernetes_platform package * update licenses * address comments * update kubernetes_platform package to include the latest spec --------- Co-authored-by: Chen Sun <[email protected]>
… pod labels and annotations (kubeflow#10393) * update kfp kubernetes sdk to include pod labels and annotations * fix unit test output order * add podmetadata changes * update argo compiler to support pod metadata * update tests * update go mod to use the latest kubernetes_platform package * update licenses * address comments * update kubernetes_platform package to include the latest spec --------- Co-authored-by: Chen Sun <[email protected]>
Description of your changes:
Part of #9714 and #9768
Fixes #10363
Update kfp backend and kubernetes sdk to support pod labels and annotations.
The pod metadata is not part of the pod spec, we can't simply update the podSpecPatch for Argo, so we need to parse the kubernetes_platform spec in the compiler and add the pod labels and annotations in the Argo container definition.
Also fixing go lint style from #10288
Checklist: