Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added s390x and ppc64le support #10766

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

R3hankhan123
Copy link

Description of your changes:
Added multiarch support for s390x and ppc64le by adding Architectural parameters wherever possible in dockerfiles and bash scripts
Checklist:

Copy link

Hi @R3hankhan123. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@hbelmiro
Copy link
Contributor

/retest

@google-oss-prow google-oss-prow bot removed the lgtm label May 1, 2024
Copy link

New changes are detected. LGTM label has been removed.

@R3hankhan123
Copy link
Author

R3hankhan123 commented May 2, 2024

@hbelmiro @chensun are the test failing because Kubernetes 1.25 is no longer supported?

@R3hankhan123 R3hankhan123 requested a review from hbelmiro May 2, 2024 05:41
@rimolive
Copy link
Member

rimolive commented May 4, 2024

@R3hankhan123 We have an known issue with the current e2e tests so for now we'll need to run them locally to ensure the PR does not introduce any breaking changes.

@github-actions github-actions bot added the Stale label Jul 4, 2024
@github-actions github-actions bot closed this Jul 25, 2024
@hbelmiro
Copy link
Contributor

@R3hankhan123 the e2e test was migrated to GitHub Actions and is working now. Can you please rebase?

/reopen

@google-oss-prow google-oss-prow bot reopened this Jul 25, 2024
Copy link

@hbelmiro: Reopened this PR.

In response to this:

@R3hankhan123 the e2e test was migrated to GitHub Actions and is working now. Can you please rebase?

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dilipgb
Copy link

dilipgb commented Jul 26, 2024

/reopen

Copy link

@dilipgb: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@R3hankhan123
Copy link
Author

/reopen

Copy link

@R3hankhan123: Failed to re-open PR: state cannot be changed. There are no new commits on the R3hankhan123:s390x branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rimolive
Copy link
Member

/rerun-all

@R3hankhan123
Copy link
Author

@rimolive @hbelmiro I can see that some github workflows are requiring maintainer's aproval.
Screenshot 2024-07-26 at 4 12 00 PM
Screenshot 2024-07-26 at 4 13 13 PM

@hbelmiro
Copy link
Contributor

/rerun-all

@hbelmiro
Copy link
Contributor

For some reason /rerun-all is not working.
@chensun do you have permission to approve the GitHub workflows to run?

Context: #10981

@R3hankhan123
Copy link
Author

Hi @hbelmiro @rimolive @vanpelt
I hope this message finds you well. I noticed that some of the tests for this pull request have not yet been triggered. Could you please let me know when the remaining tests might be triggered?

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 5, 2024

@R3hankhan123 I don't have permission to trigger them from the GitHub UI.
Due to #10981, /ok-to-test is not triggering the GitHub Actions tests.

Trying once more...

/rerun-all

@R3hankhan123
Copy link
Author

@hbelmiro @rimolive any updates on the test that are failing?

@hbelmiro
Copy link
Contributor

@R3hankhan123 please rebase your PR and then we see how it goes.

@R3hankhan123
Copy link
Author

/reopen

@R3hankhan123 R3hankhan123 reopened this Sep 20, 2024
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Sep 20, 2024
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@R3hankhan123
Copy link
Author

@hbelmiro looks like the workflows still arent being triggered automatically
Screenshot 2024-09-20 at 5 38 45 PM

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

@R3hankhan123
Copy link
Author

@hbelmiro looks like all the tests have passed and just needs the lgtm label

backend/Dockerfile.launcher Outdated Show resolved Hide resolved
backend/Makefile Outdated Show resolved Hide resolved
backend/api/Dockerfile Outdated Show resolved Hide resolved
@@ -1,11 +1,17 @@
FROM gcr.io/google.com/cloudsdktool/google-cloud-cli:alpine
FROM alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this.
@rimolive @chensun thoughts?

Copy link

@dilipgb dilipgb Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbelmiro gcr.io/google.com/cloudsdktool/google-cloud-cli:alpine image is not supporting multiple architecture. It only amd/arm architectures.

Since gcloud component installed is only kubectl (https://github.com/kubeflow/pipelines/blob/master/backend/src/cache/deployer/Dockerfile#L8) we are taking plain vanila alpine and installing all the needed packages including kubectl from binary distributions as you see in below code snippet.

backend/src/cache/deployer/deploy-cache-service.sh Outdated Show resolved Hide resolved
backend/src/cache/deployer/deploy-cache-service.sh Outdated Show resolved Hide resolved
third_party/minio/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Rehan Khan <[email protected]>
@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants