-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add PipelineConfig to DSL to re-implement pipeline-level config #11112
base: master
Are you sure you want to change the base?
feat(sdk): add PipelineConfig to DSL to re-implement pipeline-level config #11112
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/rerun-all |
f160004
to
c7ba3f6
Compare
@chensun bump to the top of your inbox :) thanks! |
KFP v1 supported setting pipeline-level configuration via a `PipelineConf` class. This class was deprecated and no replacement was added to KFP v2. add new PipelineConfig class to support setting pipeline-level configuration in KFP v2. Signed-off-by: Greg Sheremeta <[email protected]>
c7ba3f6
to
064c670
Compare
@chensun bump, looking for an ack on the approach and the proto fields :) |
@chensun bumping, can you take a look? |
Thanks for discussing this internally. Here are my responses.
Some examples:
I'm fine to put it wherever you all think is best. To clarify, is PlatformSpec the second document at the bottom?
And if so, about where should pipeline-level stuff go? Should it be a sibling of kubernetes? Note that this was my approach in #10942 -- quoting from that
but I (perhaps mistakenly) thought that that was rejected. |
@chensun bumping to the top of your inbox. Can you provide guidance on the spec questions in my previous comment? |
Description of your changes:
KFP v1 supported setting pipeline-level configuration via a
PipelineConf
class. This class was deprecated and no replacement was added to KFP v2.Add new PipelineConfig class to support setting pipeline-level configuration in KFP v2.
Note: I discussed this approach with @chensun in the KFP Community meeting on August 14 (agenda, recording). He gave preliminary approval for this approach.
Here's an example of how it would be used.
Checklist: