Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): add configurable S3 path style support #11246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntny
Copy link

@ntny ntny commented Sep 24, 2024

Description of your changes:
Resolve: #10814

This MR introduces the ability to configure the S3 path style
Currently it is hardcoded here as pathStyle
'PathStyle' will be the default setting

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @ntny. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

backend/src/v2/config/s3.go Show resolved Hide resolved
backend/src/v2/config/s3.go Outdated Show resolved Hide resolved
@ntny ntny force-pushed the feat/configurable-s3-path-style branch from c2af9f5 to 5016e4d Compare September 27, 2024 07:59
@ntny
Copy link
Author

ntny commented Sep 27, 2024

/rerun-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support S3 virtual hosted style
2 participants