fix(api): Fix pipeline.upload.swagger.json #9104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jlyaoyuli FYI, I guess FE also need to regenerate TS API library following the swagger change? |
gkcalat
reviewed
Apr 5, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gkcalat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rd-pong
pushed a commit
to rd-pong/pipelines
that referenced
this pull request
Apr 26, 2023
* fix pipeline.upload.swagger.json * remove `namespace` from upload_pipeline_version parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Follow up on #9064, while the PR addressed the backend issue, the swagger client also needs to be updated for clients (SDK and possibly UI) to correctly interpret the backend response.
For reviewers:
pipeline.upload.swagger.jsonwas manually edited, and all the rest files were auto-generated.pipeline.upload.swagger.jsonwas due to indentation fix. It would be much easier to reviewkfp_api_single_file.swagger.jsoninstead.Checklist: