Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend instructions on adding a Profile by adding LimitRange #3535

Open
gkcalat opened this issue Jun 29, 2023 · 0 comments
Open

Extend instructions on adding a Profile by adding LimitRange #3535

gkcalat opened this issue Jun 29, 2023 · 0 comments
Assignees

Comments

@gkcalat
Copy link
Member

gkcalat commented Jun 29, 2023

          @jsitu777 thank you for reporting this.

Profile controls user workloads to be within the quota. So, if you have a hard quota on CPU and memory it will reject all workloads that do no satisfy it. Unfortunately, it seems that Containers without resources will also be rejected.

Adding resources to the Argo's workflow-controller-configmap results in all containers being overwritten and having the same resources, which is probably a wrong way to fix the issue described above.

I feel we may have better solutions:

  1. Allowing default values in Profile, which will be used to fill resources for containers that do not have them. This needs to be done in Profile component. /cc @kimwnasptd
  2. Advising users to create a LimitRange whenever a Profile gets created. We need to update the documentation.

Example LimitRange:

apiVersion: v1
kind: LimitRange
metadata:
  name: <user>-limit-range
spec:
  limits:
  - default:
      cpu: 0.5
      memory: 512Mi
    defaultRequest:
      cpu: 0.01
      memory: 32Mi
    type: Container

Which can be applied a user namespace:

kubectl apply -f <yaml> -n <user>

/cc @chensun @Linchin

Originally posted by @gkcalat in kubeflow/pipelines#9089 (comment)

@gkcalat gkcalat assigned Linchin and gkcalat and unassigned Linchin Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants