Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in Katib #3811

Closed
Tracked by #3814
hbelmiro opened this issue Jul 19, 2024 · 5 comments · Fixed by #3888
Closed
Tracked by #3814

Fix broken links in Katib #3811

hbelmiro opened this issue Jul 19, 2024 · 5 comments · Fixed by #3888
Assignees

Comments

@hbelmiro
Copy link
Contributor

Now that we have Checklinks enabled in Netlify, we can fix the existing broken links we have on our TODO list.

  1. Remove Katib links from Checklinks TODO list.
  2. Fix links reported in Netlify deployment log.

#3807 can be used as a reference.

cc @andreyvelich @gaocegege @johnugeorge @sperlingxx

@varodrig
Copy link
Contributor

varodrig commented Sep 24, 2024

@hbelmiro I'm working on this. there's a link broken in the page
Page: docs/components/katib/user-guides/trial-template/
Link broken: docs/components/training/user-guides/mxnet
The page doesn't exists however, it does exist on this branch.
https://v1-9-branch.kubeflow.org/docs/components/training/user-guides/mxnet/
please recommend steps to resolve this if needed to create the page or remove the link. thanks

@varodrig
Copy link
Contributor

@hbelmiro please assign this issue to me. thank you

@hbelmiro
Copy link
Contributor Author

@hbelmiro I'm working on this. there's a link broken in the page Page: docs/components/katib/user-guides/trial-template/ Link broken: docs/components/training/user-guides/mxnet The page doesn't exists however, it does exist on this branch. https://v1-9-branch.kubeflow.org/docs/components/training/user-guides/mxnet/ please recommend steps to resolve this if needed to create the page or remove the link. thanks

You probably can remove that bullet.
@andreyvelich can you confirm?

@hbelmiro
Copy link
Contributor Author

/assign @varodrig

@hbelmiro
Copy link
Contributor Author

@varodrig since you're leaving for vacation, please send the PR with the bullet removed.
Hopefully, it will be merged when you get back, otherwise you can fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants