Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split CI manifests and user-facing examples #1663

Open
embik opened this issue Jun 14, 2023 · 4 comments
Open

Split CI manifests and user-facing examples #1663

embik opened this issue Jun 14, 2023 · 4 comments
Labels
kind/chore Updating grunt tasks etc; no production code changes. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@embik
Copy link
Member

embik commented Jun 14, 2023

Currently, some files in https://github.com/kubermatic/machine-controller/tree/main/examples are used for e2e tests and are also presented as user-facing examples in our README.

This causes problems because we tend to update examples to work for e2e tests, but that can break their compatibility with the latest released version (the latest tag points to the last release we published). This happened e.g. with the logging flags and results in invalid example files, as seen in #1655.

We should split the manifests used for CI and presented as user-facing deployment method, since the user-facing ones should always work with the latest release, but the ones used by CI should work with the main branch HEAD.
@embik embik added the kind/chore Updating grunt tasks etc; no production code changes. label Jun 14, 2023
@embik embik mentioned this issue Jun 19, 2023
Closed
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2023
@embik
Copy link
Member Author

embik commented Sep 12, 2023

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2023
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2023
@embik
Copy link
Member Author

embik commented Dec 12, 2023

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2023
@embik embik added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/chore Updating grunt tasks etc; no production code changes. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@embik @kubermatic-bot