-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LifeCycle test fails since 'unpublish' is not run #316
Comments
@timoreimann is this perhaps related to your cleanup changes? /help wanted |
/help |
@pohly: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I wonder if #297 (which I thought was long merged but I just realized I still have to follow up on) fixes this problem. |
@timoreimann even after the branch was merged, we are still getting that error |
@ArbelNathan is your driver possibly affected by the fact that cleanup currently only happens in LIFO order? Some drivers may require FIFO order which #319 is meant to address (and that I should find some time to work on soon). If that's not the case, then it might be a different problem. In that case, a dedicated issue would be appreciated if yet missing. |
this issue is about a simpler scenario than snapshots (though our driver requires LIFO order) - DeleteVolume is called before controller unpublish. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Hello @timoreimann ! according to spec. |
we are still getting the same error, is there any reason why the unpublish is not called before trying deleting the volume? |
I have been dealing with this same problem for the last couple days where my CSI driver fails the tests "volume lifecycle should work" and "volume lifecycle should be idempotent" because the csi-sanity tool calls DeleteVolume before ControllerUnpublishVolume in the cleanup path. |
@llabordehpe can you be more specific on the cause of the problem? |
Do we even know that unpublish (in cleanup only) is working? |
On branch master - in "volume lifecycle" test (func VolumeLifecycle), seems like the last method running is ControllerPublishVolumeRequest and nothing after that, which causes the test to fail since it expects unpublish.
on the other hand, on branch release-3.1, Lifecycle tests pass.
This is the failure from master branch:
The text was updated successfully, but these errors were encountered: