Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default tags don't get applied to previously created "backend" security group #2838

Open
romich opened this issue Oct 19, 2022 · 3 comments · May be fixed by #3990
Open

Default tags don't get applied to previously created "backend" security group #2838

romich opened this issue Oct 19, 2022 · 3 comments · May be fixed by #3990
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@romich
Copy link

romich commented Oct 19, 2022

Describe the bug
Tags from --default-tags argument don't get applied to previously created "backend" security group.

Steps to reproduce

  1. Deploy chart with minimal config.
  2. Create at least 1 ALB Ingress.
  3. Update chart, providing defaultTags option.
  4. Observe default tags only on frontend security group.

Expected outcome
Both frontend and backend security groups get provided tags.

Environment

  • AWS Load Balancer controller version: v2.4.4
  • EKS version: v1.23.10-eks-15b7512

Additional Context:
n/a
@kishorj
Copy link
Collaborator

kishorj commented Oct 19, 2022

/kind feature
@romich, Thanks for letting us know, we will fix it in a patch release. Currently the tags are applied only during backend SG creation.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2022
@kishorj kishorj added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 19, 2022
@bartpeeters bartpeeters mentioned this issue Oct 31, 2022
Closed
6 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@Hokwang
Copy link

Hokwang commented Jun 8, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 8, 2023
@phuhung273 phuhung273 linked a pull request Dec 20, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sync created Backend SG tags phuhung273/aws-load-balancer-controller
5 participants
@Hokwang @romich @kishorj @k8s-ci-robot @k8s-triage-robot