ListVolumes API doesn't list the volumes that are created in an external resource group

[nearora-msft]

What happened:
ListVolumes API doesn't list the volumes that are created in a different resource group

What you expected to happen:
ListVolumes API should list all the disks that are attached to the nodes in a resource group

How to reproduce it:

Anything else we need to know?:
With azuredisk csi driver, disks might get created in different resource groups. The current implementation of ListVolumes(#618) only supports the default case when the disks are created in the current resource group

Environment:

• CSI Driver version:
• Kubernetes version (use kubectl version):
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[andyzhangx]

use d.cloud.KubeClient.CoreV1().PersistentVolumes() to get all PV info and then get all diskURI from pv.csi.volumeid and then get disk.ManagedBy, that would provide complete disk list, could refer to:

• d.cloud.KubeClient.CoreV1() interface
  https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/bb2550070c810ffe94c35eb38aad09c6a3136ade/pkg/azurefile/azurefile.go#L556

this would require much more work, while it could list all disks this cluster is using, otherwise it could not cover all disks and may provide incomplete disk list, not sure what would happen if disk list is incomplete.

#618 (comment)

And we could still leverage original cloud.DisksClient.ListByResourceGroup API to get disk's ManagedBy property in batch.

[andyzhangx]

the above proposal would introduce d.cloud.KubeClient dependency, if user's cluster does not set kubeconfig, then it could fall back to use original ListVolumes way, that would be robust

[sunpa93]

/assign